Change in osmo-bts[master]: osmo-bts-trx: send dummy FACCH in the absense of RTP frames

fixeria gerrit-no-reply at lists.osmocom.org
Thu Aug 19 08:13:20 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24846 )

Change subject: osmo-bts-trx: send dummy FACCH in the absense of RTP frames
......................................................................


Patch Set 3:

> Patch Set 3: Code-Review+1
> 
> That is an interesting solution to the problem, also interesting that the nanoBTS does it the same way. I would have expected it would just send silent voice frames.
> 
> I guess you did check back that this does not interfere with DTX somehow but I am also not sure what happens on the RTP side during a DTX silence period. I just wanted to make sure that you are aware of this.

Hi dexter,

this is a very good point about DTXd. As far as I can say, it's currently broken in osmo-bts-trx. An alternative solution to my approach would be to move FACCH frame injection to the upper layers.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24846
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I868afecbcb6890f40c8f146e3ce00e836b794dd3
Gerrit-Change-Number: 24846
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 19 Aug 2021 08:13:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210819/560ccafd/attachment.htm>


More information about the gerrit-log mailing list