This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25115 ) Change subject: mgcp_client: do not print (null) when address is ANY ...................................................................... mgcp_client: do not print (null) when address is ANY When the address is set to ANY, the address string is NULL. The log then prints "(null)" where the address normaly would be. This looks odd, lets print "(any)" instead. Change-Id: I2ea138827ee5b9f40d352bf594364ee930520609 --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 440cd96..225b1ee 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -824,7 +824,8 @@ /* Choose a new port number to try next */ LOGP(DLMGCP, LOGL_NOTICE, "MGCPGW failed to bind to %s:%u, retrying with port %u\n", - mgcp->actual.local_addr, mgcp->actual.local_port, mgcp->actual.local_port + 1); + mgcp->actual.local_addr ? mgcp->actual.local_addr : "(any)", mgcp->actual.local_port, + mgcp->actual.local_port + 1); mgcp->actual.local_port++; } @@ -892,8 +893,9 @@ if (rc < 0) { LOGP(DLMGCP, LOGL_FATAL, "Failed to initialize socket %s:%u -> %s:%u for MGCP GW: %s\n", - mgcp->actual.local_addr, mgcp->actual.local_port, - mgcp->actual.remote_addr, mgcp->actual.remote_port, strerror(errno)); + mgcp->actual.local_addr ? mgcp->actual.local_addr : "(any)", mgcp->actual.local_port, + mgcp->actual.remote_addr ? mgcp->actual.local_addr : "(any)", mgcp->actual.remote_port, + strerror(errno)); goto error_close_fd; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2ea138827ee5b9f40d352bf594364ee930520609 Gerrit-Change-Number: 25115 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210817/1555cd03/attachment.htm>