Change in osmo-ci[master]: lint: ignore EMBEDDED_FILENAME

osmith gerrit-no-reply at lists.osmocom.org
Mon Aug 16 11:23:45 UTC 2021


osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/25197 )


Change subject: lint: ignore EMBEDDED_FILENAME
......................................................................

lint: ignore EMBEDDED_FILENAME

Mentioning the file in itself is useful sometimes (e.g. when explaining
how to use a contrib script). So do not let the linter fail here.

Related: OS#5087
Change-Id: I151b97bc7f2fe83898c0598db54360807956993c
---
M lint/checkpatch/checkpatch_osmo.sh
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/97/25197/1

diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh
index abeed56..b465b5a 100755
--- a/lint/checkpatch/checkpatch_osmo.sh
+++ b/lint/checkpatch/checkpatch_osmo.sh
@@ -14,6 +14,7 @@
 # * COMPLEX_MACRO: we don't use parentheses when building macros of strings across multiple lines
 # * CONSTANT_COMPARISON: not followed: "Comparisons should place the constant on the right side"
 # * DEEP_INDENTATION: warns about many leading tabs, not useful if changing existing code without refactoring
+# * EMBEDDED_FILENAME: this is useful sometimes (e.g. explaining how to use a script), so do not fail here
 # * EMBEDDED_FUNCTION_NAME: often __func__ isn't used, arguably not much benefit in changing this when touching code
 # * EXECUTE_PERMISSIONS: not followed, files need to be executable: git-version-gen, some in debian/
 # * FILE_PATH_CHANGES: we don't use a MAINTAINERS file
@@ -42,6 +43,7 @@
 	--ignore COMPLEX_MACRO \
 	--ignore CONSTANT_COMPARISON \
 	--ignore DEEP_INDENTATION \
+	--ignore EMBEDDED_FILENAME \
 	--ignore EMBEDDED_FUNCTION_NAME \
 	--ignore EXECUTE_PERMISSIONS \
 	--ignore FILE_PATH_CHANGES \

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25197
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I151b97bc7f2fe83898c0598db54360807956993c
Gerrit-Change-Number: 25197
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210816/1ad710c8/attachment.htm>


More information about the gerrit-log mailing list