Change in osmo-ttcn3-hacks[master]: stp: TC_rkm_unreg_never_registered: !latest

laforge gerrit-no-reply at lists.osmocom.org
Sun Aug 15 17:17:58 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25185 )

Change subject: stp: TC_rkm_unreg_never_registered: !latest
......................................................................

stp: TC_rkm_unreg_never_registered: !latest

Disable test TC_rkm_unreg_never_registered for current latest version of
osmo-stp (1.4.0), as it does not clean up properly and now causes other
tests to fail.

With this patch, test results for -latest are restored to how it was
before I7d2f9eb298778a8e60c7e73f314bc73528e85406 and
I31fcba85d23a8767eb0ceb513ff5b440558a475b were merged.

Related: OS#4239
Change-Id: Ice8fe9597a0a12eb4ec26172982a0f5cd01a148b
---
M stp/STP_Tests_M3UA.ttcn
1 file changed, 12 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  daniel: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn
index b97d4da..1c3b01d 100644
--- a/stp/STP_Tests_M3UA.ttcn
+++ b/stp/STP_Tests_M3UA.ttcn
@@ -1019,7 +1019,18 @@
 	execute( TC_rkm_reg_static_notpermitted() );
 	execute( TC_rkm_reg_static_permitted() );
 	execute( TC_rkm_reg_dynamic_permitted() );
-	execute( TC_rkm_unreg_never_registered() );
+	/* This test has never passed in osmo-stp <= 1.4.0, because it needs
+	 * patch Ie5d84d06e7d5d32c8a22f770f71a5449f4a78484 which was added
+	 * afterwards. Disable the test for <= 1.4.0, because the test does not
+	 * clean up properly and - after other tests were extended - they are
+	 * now failing in this not properly cleaned up state. After some hours
+	 * of figuring out that it is definitively this test and trying to
+	 * figure out what exactly is not cleaning up properly, I decided to
+	 * just temporarily disable the test for -latest instead of spending
+	 * even more time on it. */
+	if (mp_osmo_stp_newer_than_1_4_0) {
+		execute( TC_rkm_unreg_never_registered() );
+	}
 	execute( TC_rkm_unreg_invalid() );
 	execute( TC_rkm_unreg_registered() );
 	execute( TC_rkm_unreg_active() );

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25185
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ice8fe9597a0a12eb4ec26172982a0f5cd01a148b
Gerrit-Change-Number: 25185
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210815/a25cef52/attachment.htm>


More information about the gerrit-log mailing list