Change in osmo-ttcn3-hacks[master]: stp: rename mp_stp_has_asp_quirk

laforge gerrit-no-reply at lists.osmocom.org
Sun Aug 15 17:17:58 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25184 )

Change subject: stp: rename mp_stp_has_asp_quirk
......................................................................

stp: rename mp_stp_has_asp_quirk

Rename the option to mp_osmo_stp_newer_than_1_4_0, because I'm going to
use the variable in the next patch for something unrelated to the asp
quirk and so we can avoid introducing another variable.

Related: docker-playground I6a32398242b53c827a94cf65e4a35900a7c4171a
Related: OS#4239
Change-Id: I43b1aa2c029c88c88320d40f60df46a5eb6c4c24
---
M stp/STP_Tests_M3UA.ttcn
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  daniel: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn
index 13703d0..b97d4da 100644
--- a/stp/STP_Tests_M3UA.ttcn
+++ b/stp/STP_Tests_M3UA.ttcn
@@ -73,8 +73,8 @@
 	integer mp_recovery_timeout_msec := 2000;
 	charstring mp_sccp_service_type := "mtp3_itu";
 
-	/* does the STP support the 'asp quirk' command? */
-	boolean mp_stp_has_asp_quirk := true;
+	/* is osmo-stp newer than 1.4.0? */
+	boolean mp_osmo_stp_newer_than_1_4_0 := true;
 }
 
 type record M3uaConfig {
@@ -1034,7 +1034,7 @@
 	execute( TC_clnt_asp_to_sg() );
 
 	/* remove the condition if osmo-stp > 1.4.0 is released */
-	if (mp_stp_has_asp_quirk) {
+	if (mp_osmo_stp_newer_than_1_4_0) {
 		execute( TC_clnt_quirk_no_notify_asp_act() );
 		execute( TC_clnt_no_daud_in_asp() );
 		execute( TC_clnt_quirk_daud_in_asp() );

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25184
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I43b1aa2c029c88c88320d40f60df46a5eb6c4c24
Gerrit-Change-Number: 25184
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210815/a6627c9e/attachment.htm>


More information about the gerrit-log mailing list