Change in libosmocore[master]: gprs_ns2_udp: don't start the NSVC fsm for SNS

laforge gerrit-no-reply at lists.osmocom.org
Fri Aug 13 09:55:51 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25142 )

Change subject: gprs_ns2_udp: don't start the NSVC fsm for SNS
......................................................................

gprs_ns2_udp: don't start the NSVC fsm for SNS

The SNS code will always create NSVC on it's own. The only case
when the SNS dialect allows dynamic NSE/NSVC is on the SGSN side when accepting
dynamic NSE and receiving the first SNS SIZE. In this case the NSVC FSM must not be started yet.
Prevents sending NS_ALIVE before the SNS configuration has been
finished.

Change-Id: I86275c99432262b3c19c1ded9a77090b74303bc8
---
M src/gb/gprs_ns2_udp.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  daniel: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gb/gprs_ns2_udp.c b/src/gb/gprs_ns2_udp.c
index 428fd4a..4816021 100644
--- a/src/gb/gprs_ns2_udp.c
+++ b/src/gb/gprs_ns2_udp.c
@@ -247,7 +247,9 @@
 			goto out;
 		case NS2_CS_CREATED:
 			ns2_driver_alloc_vc(bind, nsvc, &saddr);
-			ns2_vc_fsm_start(nsvc);
+			/* only start the fsm for non SNS. SNS will take care of its own */
+			if (nsvc->nse->dialect != GPRS_NS2_DIALECT_SNS)
+				ns2_vc_fsm_start(nsvc);
 			break;
 		}
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25142
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I86275c99432262b3c19c1ded9a77090b74303bc8
Gerrit-Change-Number: 25142
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210813/6c9769b4/attachment.htm>


More information about the gerrit-log mailing list