Change in osmo-mgw[master]: libosmo-mgcp-client: extend the mgcp_client for MGW pooling

dexter gerrit-no-reply at lists.osmocom.org
Wed Aug 11 08:54:04 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25120 )

Change subject: libosmo-mgcp-client: extend the mgcp_client for MGW pooling
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/25120/9/include/osmocom/mgcp_client/mgcp_client_pool.h 
File include/osmocom/mgcp_client/mgcp_client_pool.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/25120/9/include/osmocom/mgcp_client/mgcp_client_pool.h@9 
PS9, Line 9: void mgcp_client_pool_register_single(struct mgcp_client_pool *pool, struct mgcp_client *mgcp_client);
> the naming of those function is inconsistent.  Either you first put the object first, i.e. […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25120
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icaaba0e470e916eefddfee750b83f5f65291a6b0
Gerrit-Change-Number: 25120
Gerrit-PatchSet: 12
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Aug 2021 08:54:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210811/b69195d7/attachment.htm>


More information about the gerrit-log mailing list