Change in osmo-pcu[master]: fix: handle NULL return of as_dl_tbf() and as_ul_tbf()

osmith gerrit-no-reply at lists.osmocom.org
Wed Aug 11 07:44:56 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25182 )

Change subject: fix: handle NULL return of as_dl_tbf() and as_ul_tbf()
......................................................................


Patch Set 2: Code-Review+1

Patch looks sane to me.

Maybe log a message if as_dl_tbf and as_ul_tbf are NULL instead of silently doing nothing? That hopefully helps with figuring out why this happens.

Note that Pau has patches pending to completely refactor TBF logic to use FSM: https://gerrit.osmocom.org/c/osmo-pcu/+/25011


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25182
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I8ce21be6836549b47a606c00b793d6f005964c5c
Gerrit-Change-Number: 25182
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Aug 2021 07:44:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210811/86ab05b6/attachment.htm>


More information about the gerrit-log mailing list