Change in osmo-pcu[master]: fix: handle NULL return of as_dl_tbf() and as_ul_tbf()

neels gerrit-no-reply at lists.osmocom.org
Wed Aug 11 01:31:34 UTC 2021


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-pcu/+/25182

to look at the new patch set (#2).

Change subject: fix: handle NULL return of as_dl_tbf() and as_ul_tbf()
......................................................................

fix: handle NULL return of as_dl_tbf() and as_ul_tbf()

Go through all callers of as_dl_tbf() and as_ul_tbf(), and make sure
they can handle the possible NULL return value.

OS#5205 reports a NULL deref crash of osmo-pcu at pdch.cpp:525. The
immediate cause is that as_dl_tbf() may well return NULL, which this
caller does not handle and instead dereferences immediately.
This is a code path that apparently assumes that a DL-TBF should always
be present. The higher level cause for the NULL DL-TBF has not been
identified.

Related: OS#5205 SYS#5561
Change-Id: I8ce21be6836549b47a606c00b793d6f005964c5c
---
M src/bts.cpp
M src/gprs_ms.c
M src/gprs_rlcmac_sched.cpp
M src/gprs_rlcmac_ts_alloc.cpp
M src/pdch.cpp
M src/tbf.cpp
6 files changed, 57 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/82/25182/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25182
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I8ce21be6836549b47a606c00b793d6f005964c5c
Gerrit-Change-Number: 25182
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210811/fd57db80/attachment.htm>


More information about the gerrit-log mailing list