Change in osmo-mgw[master]: mgcp_protocol: get rid of policy_cb and change_cb

daniel gerrit-no-reply at lists.osmocom.org
Mon Aug 9 10:41:13 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25126 )

Change subject: mgcp_protocol: get rid of policy_cb and change_cb
......................................................................


Patch Set 2: Code-Review+2

> Patch Set 2:
> 
> Has this ever been used anywhere? I can see the old osmo-bsc_nat installed a custom policy_cb (bsc_mgcp_policy_cb in bsc_mgcp_utils.c).
> See SYS#5560 which sounds like osmo-bsc_nat will be used in the future so maybe we'll need a policy_cb then.

We just discused this and came to the conclusion that it can be removed.
The old osmo-bsc_nat had the mgw built-in and used policy_cb to use osmux on the backhaul.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25126
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I19f67db1c56473f47338b56114f6bbae8981d067
Gerrit-Change-Number: 25126
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Aug 2021 10:41:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210809/04e689f8/attachment.htm>


More information about the gerrit-log mailing list