Change in osmo-mgw[master]: libosmo-mgcp-client: extend the mgcp_client for MGW pooling

laforge gerrit-no-reply at lists.osmocom.org
Fri Aug 6 14:10:29 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25120 )

Change subject: libosmo-mgcp-client: extend the mgcp_client for MGW pooling
......................................................................


Patch Set 9: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/25120/9/include/osmocom/mgcp_client/mgcp_client_pool.h 
File include/osmocom/mgcp_client/mgcp_client_pool.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/25120/9/include/osmocom/mgcp_client/mgcp_client_pool.h@9 
PS9, Line 9: void mgcp_client_pool_register_single(struct mgcp_client_pool *pool, struct mgcp_client *mgcp_client);
the naming of those function is inconsistent.  Either you first put the object first, i.e. all start with mgcp_client_pool_*(), or you put the action first and the object last, like mgcp_client_*_pool().

I strongly prefer the first approach, as it makes it very easy to grep for mgcp_client_pool and then get all related function calls.  Also, the symbols are grouped together when sorted alphabetically, ...

In the end, it's your choice. but please don't mix both styles in the same part of code.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25120
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icaaba0e470e916eefddfee750b83f5f65291a6b0
Gerrit-Change-Number: 25120
Gerrit-PatchSet: 9
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 06 Aug 2021 14:10:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210806/b60857c6/attachment.htm>


More information about the gerrit-log mailing list