Change in osmo-pcap[master]: Change default ports of client, server

osmith gerrit-no-reply at lists.osmocom.org
Fri Aug 6 14:07:21 UTC 2021


osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/25131 )

Change subject: Change default ports of client, server
......................................................................

Change default ports of client, server

Resolve conflict with other Osmocom software by moving ports:

osmo-pcap-client 4237 -> 4227
osmo-pcap-server 4238 -> 4228

Notably the defines OSMO_VTY_PORT_PCAP_CLIENT and _SERVER are currently
not provided by libosmocore, but will be added with the related commit.

Related: OS#5203
Related: libosmocore I098f211370bba61995ce424ab64029bdd4c49e2d
Change-Id: I3b18b1fbbca2799f868f28104e2f5d513f93d46c
---
M include/osmo-pcap/common.h
M osmoappdesc.py
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/include/osmo-pcap/common.h b/include/osmo-pcap/common.h
index 79080a2..7ac5bb0 100644
--- a/include/osmo-pcap/common.h
+++ b/include/osmo-pcap/common.h
@@ -32,10 +32,10 @@
 
 /* support old versions of libosmocore */
 #ifndef OSMO_VTY_PORT_PCAP_CLIENT
-#define OSMO_VTY_PORT_PCAP_CLIENT	4237
+#define OSMO_VTY_PORT_PCAP_CLIENT	4227
 #endif
 #ifndef OSMO_VTY_PORT_PCAP_SERVER
-#define OSMO_VTY_PORT_PCAP_SERVER	4238
+#define OSMO_VTY_PORT_PCAP_SERVER	4228
 #endif
 
 enum {
diff --git a/osmoappdesc.py b/osmoappdesc.py
index 331e6a9..36fef63 100644
--- a/osmoappdesc.py
+++ b/osmoappdesc.py
@@ -22,8 +22,8 @@
 }
 
 apps = [
-    (4238, "src/osmo-pcap-server", "OsmoPCAPServer", "osmo-pcap-server"),
-    (4237, "src/osmo-pcap-client", "OsmoPCAPClient", "osmo-pcap-client"),
+    (4228, "src/osmo-pcap-server", "OsmoPCAPServer", "osmo-pcap-server"),
+    (4227, "src/osmo-pcap-client", "OsmoPCAPClient", "osmo-pcap-client"),
         ]
 
 vty_command = ["src/osmo-pcap-server", "-c", "doc/examples/osmo-pcap-server/osmo-pcap-server.cfg"]

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/25131
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I3b18b1fbbca2799f868f28104e2f5d513f93d46c
Gerrit-Change-Number: 25131
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210806/48005f47/attachment.htm>


More information about the gerrit-log mailing list