Change in osmo-gsm-tester[master]: Fix AmarisoftEPC local execution

laforge gerrit-no-reply at lists.osmocom.org
Fri Aug 6 14:06:57 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/25127 )

Change subject: Fix AmarisoftEPC local execution
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/25127/2/src/osmo_gsm_tester/obj/ms_amarisoft.py 
File src/osmo_gsm_tester/obj/ms_amarisoft.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/25127/2/src/osmo_gsm_tester/obj/ms_amarisoft.py@185 
PS2, Line 185:         util.change_elf_rpath(self.inst.child('', "lteue-*"), str(util.prepend_library_path(self.inst)), self.run_dir.new_dir('patchelf2'))
> Passing 'lteue-*' does not work because the asterisks is interpreted as a string. […]
if you look at the implementation of change_elf_rpath() in utils.py you will clearly see that it expects a single file name and then changes the rpath of that filename.  If you have multiple files, I suggest you first expand them in  your code here and then iterate over the list of files, calling change_elf_rpath() for each of them.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/25127
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I4f7ef8fdf8a18b793fdc4b654cb85838d513aac2
Gerrit-Change-Number: 25127
Gerrit-PatchSet: 2
Gerrit-Owner: ninjab3s <nils.fuerste at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 06 Aug 2021 14:06:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ninjab3s <nils.fuerste at softwareradiosystems.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210806/af94a066/attachment.htm>


More information about the gerrit-log mailing list