Change in osmo-ttcn3-hacks[master]: bsc: improve error log for "RSL for unknown Dchan"

laforge gerrit-no-reply at lists.osmocom.org
Fri Aug 6 14:03:31 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25023 )

Change subject: bsc: improve error log for "RSL for unknown Dchan"
......................................................................

bsc: improve error log for "RSL for unknown Dchan"

The failure verdict includes the RSL message that could not be
associated with a handling component, but ttcn_logformat does not format
that message. Add an identical log() that gets formatted nicely.

Change-Id: Ibb8f60671e78075492783cba560a8229ba5a380b
---
M library/RSL_Emulation.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  dexter: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index 969dbce..31647df 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -612,6 +612,8 @@
 				log("Storing an RSL message in the waiting queue");
 				WaitingQueue := WaitingQueue & { rx_rsl };
 			} else {
+				log("Error: RSL for unknown Dchan (streamId ", rx_rsl.streamId, ", chan_nr ",
+					   rx_rsl.rsl.ies[0].body.chan_nr, "): ", rx_rsl);
 				setverdict(fail, "RSL for unknown Dchan");
 				mtc.stop;
 			}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25023
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibb8f60671e78075492783cba560a8229ba5a380b
Gerrit-Change-Number: 25023
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210806/5f15f85f/attachment.htm>


More information about the gerrit-log mailing list