Change in osmo-bsc[master]: osmo_bsc_main: integrate MGW pooling into osmo-bsc

osmith gerrit-no-reply at lists.osmocom.org
Thu Aug 5 13:09:53 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25123 )

Change subject: osmo_bsc_main: integrate MGW pooling into osmo-bsc
......................................................................


Patch Set 1: Verified-1

(14 comments)

just cosmetics and one block that could probably be simplified. rest looks good!

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc 
File doc/manuals/chapters/mgwpool.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@9 
PS1, Line 9: placed
placed,


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@26 
PS1, Line 26: l
L


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@26 
PS1, Line 26:  
,


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@38 
PS1, Line 38: to
To


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@38 
PS1, Line 38: instances so
instances, so


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@39 
PS1, Line 39: interfere each
interfere with each other


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@43 
PS1, Line 43: work
works


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@53 
PS1, Line 53:   
spaces at the end of the line, also below (gerrit highlights them)


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@112 
PS1, Line 112: mgc
mgw


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/mgwpool.adoc@113 
PS1, Line 113: restarting
reconnecting? (that's the terminology used below, so I'd also use it here)


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/running.adoc 
File doc/manuals/chapters/running.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/running.adoc@147 
PS1, Line 147: See also See also
twice


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/doc/manuals/chapters/running.adoc@148 
PS1, Line 148: 
In the other chapter and in the code you say that this is now the legacy method of configuration. So maybe call it that in this chapter too?


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/src/osmo-bsc/bsc_subscr_conn_fsm.c 
File src/osmo-bsc/bsc_subscr_conn_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@556 
PS1, Line 556: 		}
this block is the same for both parts of the if ... else, right? so move it above the if and only have it once?


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/1/src/osmo-bsc/bsc_vty.c@3386 
PS1, Line 3386: 
(unintended?)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25123
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8f33ab2cea04b545c403a6fe479aa963a0fc0d0d
Gerrit-Change-Number: 25123
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Aug 2021 13:09:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210805/872da619/attachment.htm>


More information about the gerrit-log mailing list