Change in osmo-bsc[master]: osmo_bsc_main: integrate MGW pooling into osmo-bsc

osmith gerrit-no-reply at
Thu Aug 5 13:09:53 UTC 2021

osmith has posted comments on this change. ( )

Change subject: osmo_bsc_main: integrate MGW pooling into osmo-bsc

Patch Set 1: Verified-1


just cosmetics and one block that could probably be simplified. rest looks good! 
File doc/manuals/chapters/mgwpool.adoc: 
PS1, Line 9: placed
PS1, Line 26: l
PS1, Line 26:  
PS1, Line 38: to
PS1, Line 38: instances so
instances, so 
PS1, Line 39: interfere each
interfere with each other 
PS1, Line 43: work
PS1, Line 53:   
spaces at the end of the line, also below (gerrit highlights them) 
PS1, Line 112: mgc
PS1, Line 113: restarting
reconnecting? (that's the terminology used below, so I'd also use it here) 
File doc/manuals/chapters/running.adoc: 
PS1, Line 147: See also See also
PS1, Line 148: 
In the other chapter and in the code you say that this is now the legacy method of configuration. So maybe call it that in this chapter too? 
File src/osmo-bsc/bsc_subscr_conn_fsm.c: 
PS1, Line 556: 		}
this block is the same for both parts of the if ... else, right? so move it above the if and only have it once? 
File src/osmo-bsc/bsc_vty.c: 
PS1, Line 3386: 

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8f33ab2cea04b545c403a6fe479aa963a0fc0d0d
Gerrit-Change-Number: 25123
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at>
Gerrit-Comment-Date: Thu, 05 Aug 2021 13:09:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list