Change in osmo-mgw[master]: mgcp_client: refactor function init_socket

osmith gerrit-no-reply at lists.osmocom.org
Thu Aug 5 12:31:03 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25125 )

Change subject: mgcp_client: refactor function init_socket
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/25125/1/src/libosmo-mgcp-client/mgcp_client.c 
File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25125/1/src/libosmo-mgcp-client/mgcp_client.c@835 
PS1, Line 835: 		mgcp->actual.local_port++;
I'd wrap this in

 } else {
        /* Choose a new port...

Otherwise it will print an extra line for retry_n_ports > 0, e.g. for retry_n_ports = 1:

  MGCPGW failed to bind to %s:%d, retrying with port %d -- check configuration!
  MGCPGW failed to bind to %s:%d -- check configuration!
  MGCPGW failed to bind to %s:%d, retrying with port %d -- check configuration! # <--- extra line
  MGCPGW failed to find a port to bind on %u times -- check configuration!



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25125
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ifd65511daa92fbe610f52da1c4c3b6a7c761d890
Gerrit-Change-Number: 25125
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Aug 2021 12:31:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210805/7164093d/attachment.htm>


More information about the gerrit-log mailing list