Change in osmo-mgw[master]: mgcp_ratectr: do not set talloc destructor on library allocated item

dexter gerrit-no-reply at lists.osmocom.org
Wed Aug 4 15:19:43 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25103 )

Change subject: mgcp_ratectr: do not set talloc destructor on library allocated item
......................................................................


Patch Set 6:

(3 comments)

https://gerrit.osmocom.org/c/osmo-mgw/+/25103/5//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/25103/5//COMMIT_MSG@17 
PS5, Line 17: SYS#5201
> OS#5201?
Done


https://gerrit.osmocom.org/c/osmo-mgw/+/25103/5/src/libosmo-mgcp/mgcp_protocol.c 
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25103/5/src/libosmo-mgcp/mgcp_protocol.c@1656 
PS5, Line 1656: 	talloc_free(cfg);
> I don't think this is needed, see https://talloc.samba.org/talloc/doc/html/group__talloc. […]
Done


https://gerrit.osmocom.org/c/osmo-mgw/+/25103/5/src/libosmo-mgcp/mgcp_trunk.c 
File src/libosmo-mgcp/mgcp_trunk.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25103/5/src/libosmo-mgcp/mgcp_trunk.c@45 
PS5, Line 45: 	talloc_free(trunk);
> Same
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25103
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ifc5091e9f95cc721e58d1eb2e55b97102c497706
Gerrit-Change-Number: 25103
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Aug 2021 15:19:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210804/c94808c0/attachment.htm>


More information about the gerrit-log mailing list