Change in osmo-mgw[master]: mgcp_client: allow to reset endpoints on startup

daniel gerrit-no-reply at lists.osmocom.org
Wed Aug 4 09:29:35 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25008 )

Change subject: mgcp_client: allow to reset endpoints on startup
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/25008/11/src/libosmo-mgcp-client/mgcp_client_vty.c 
File src/libosmo-mgcp-client/mgcp_client_vty.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25008/11/src/libosmo-mgcp-client/mgcp_client_vty.c@208 
PS11, Line 208: 	llist_for_each_entry(reset_ep, &global_mgcp_client_conf->reset_epnames, list) {
llist_for_each_entry_safe could be used here to remove the endpoint inside the loop.

Actually, since you break after the free anyway even the non-safe variant should work. Just return CMD_SUCCESS from inside the loop.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25008
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I47e7ff858d5067b46d52329be5f362ff61c0dff8
Gerrit-Change-Number: 25008
Gerrit-PatchSet: 11
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Aug 2021 09:29:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210804/01a01be8/attachment.htm>


More information about the gerrit-log mailing list