Change in libosmo-sccp[master]: m3ua: fix m3ua_encode_dupu

laforge gerrit-no-reply at lists.osmocom.org
Mon Aug 2 15:01:30 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/25033 )

Change subject: m3ua: fix m3ua_encode_dupu
......................................................................

m3ua: fix m3ua_encode_dupu

Fix wrong header and swapped user / cause values (see RFC 4666). This
makes TC_ssnm_distribution_dupu pass.

Change-Id: I717b64d13d12a2781c90e4d2f83643331797bed4
---
M src/m3ua.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/m3ua.c b/src/m3ua.c
index 4583683..607813f 100644
--- a/src/m3ua.c
+++ b/src/m3ua.c
@@ -820,9 +820,9 @@
 					const char *info_string)
 {
 	struct xua_msg *xua = xua_msg_alloc();
-	uint32_t user_cause = (user << 16) | cause;
+	uint32_t user_cause = (cause << 16) | user;
 
-	xua->hdr = XUA_HDR(M3UA_MSGC_SNM, M3UA_SNM_DUNA);
+	xua->hdr = XUA_HDR(M3UA_MSGC_SNM, M3UA_SNM_DUPU);
 	xua->hdr.version = M3UA_VERSION;
 	if (rctx)
 		xua_msg_add_data(xua, M3UA_IEI_ROUTE_CTX, num_rctx * sizeof(*rctx), (const uint8_t *)rctx);

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/25033
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I717b64d13d12a2781c90e4d2f83643331797bed4
Gerrit-Change-Number: 25033
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210802/b10f69e2/attachment.htm>


More information about the gerrit-log mailing list