Change in osmo-ttcn3-hacks[master]: gbproxy: Fix race condition checking for unblocked BVC

laforge gerrit-no-reply at lists.osmocom.org
Mon Aug 2 15:00:46 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25025 )

Change subject: gbproxy: Fix race condition checking for unblocked BVC
......................................................................

gbproxy: Fix race condition checking for unblocked BVC

It sometimes happens that the ttcn3 test checks the BVC FSM state before
the gbproxy had time to process the BVC_RESET_ACK from the "SGSN". It
then reports the state WAIT_RESET_ACK which will fail the test.

Introduce a small wait to give the gbproxy some more time.

Change-Id: Ic31b2188195c5d76b2d5aac9fa1f0b4efa5ca8b2
---
M gbproxy/GBProxy_Tests.ttcn
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn
index 6aa5e0c..035a47d 100644
--- a/gbproxy/GBProxy_Tests.ttcn
+++ b/gbproxy/GBProxy_Tests.ttcn
@@ -631,6 +631,10 @@
 		}
 	}
 
+	/* Wait to ensure the gbproxy processed the RESET_ACK messages from the SGSN.
+	 * Otherwise the state might still be WAIT_RESET_ACK */
+	f_sleep(0.2);
+
 	/* verify all SGSN-side BVC FSM in IUT are UNBLOCKED */
 	for (i := 0; i < lengthof(mp_nsconfig_sgsn); i := i+1) {
 		f_bvc_fsm_ensure_state(mp_nsconfig_sgsn[i].nsei, 0, "UNBLOCKED");

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25025
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic31b2188195c5d76b2d5aac9fa1f0b4efa5ca8b2
Gerrit-Change-Number: 25025
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210802/33ee781d/attachment.htm>


More information about the gerrit-log mailing list