This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25008 ) Change subject: mgcp_client: allow to reset endpoints on startup ...................................................................... Patch Set 8: (5 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/25008/7/src/libosmo-mgcp-client/mgcp_client.c File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25008/7/src/libosmo-mgcp-client/mgcp_client.c@a912 PS7, Line 912: } > moving this function seems like an unrelated change, maybe put it in a separate commit? Its not unrelated, I need this function in mgcp_client_connect now, which is more up. That is why I moved it. https://gerrit.osmocom.org/c/osmo-mgw/+/25008/7/src/libosmo-mgcp-client/mgcp_client.c@856 PS7, Line 856: Fromat > Format Done https://gerrit.osmocom.org/c/osmo-mgw/+/25008/7/src/libosmo-mgcp-client/mgcp_client_vty.c File src/libosmo-mgcp-client/mgcp_client_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25008/7/src/libosmo-mgcp-client/mgcp_client_vty.c@178 PS7, Line 178: for (i = 0; i < strlen(argv[0]); i++) { > How about, instead of the for and if: […] Done https://gerrit.osmocom.org/c/osmo-mgw/+/25008/7/src/libosmo-mgcp-client/mgcp_client_vty.c@193 PS7, Line 193: return CMD_WARNING; > reset_ep is not deallocated in this code path Done https://gerrit.osmocom.org/c/osmo-mgw/+/25008/7/src/libosmo-mgcp-client/mgcp_client_vty.c@204 PS7, Line 204: MGW_STR "emove an endpoint name from the reset-endpoint list, e.g. 'rtpbridge/*'\n" > "emove -> "remove Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25008 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I47e7ff858d5067b46d52329be5f362ff61c0dff8 Gerrit-Change-Number: 25008 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-CC: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Mon, 02 Aug 2021 11:08:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210802/e01df1d0/attachment.htm>