Change in osmocom-bb[master]: trx_toolkit/trx_sniff.py: enrich decoding error messages

fixeria gerrit-no-reply at lists.osmocom.org
Fri Apr 30 20:34:12 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24022 )


Change subject: trx_toolkit/trx_sniff.py: enrich decoding error messages
......................................................................

trx_toolkit/trx_sniff.py: enrich decoding error messages

This change is similar to Iec80890e52f7aa24c145356b5f2e1f66a47fbd4c.

Change-Id: I625f5ae0ed9373cbece5f2201759ed0b51f0db68
Related: OS#4006, SYS#4895
---
M src/target/trx_toolkit/trx_sniff.py
1 file changed, 2 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/22/24022/1

diff --git a/src/target/trx_toolkit/trx_sniff.py b/src/target/trx_toolkit/trx_sniff.py
index 389a663..1e8d17e 100755
--- a/src/target/trx_toolkit/trx_sniff.py
+++ b/src/target/trx_toolkit/trx_sniff.py
@@ -110,11 +110,8 @@
 		try:
 			msg.from_bytes(msg_raw)
 			msg.validate()
-		except ValueError as e:
-			desc = msg.desc_hdr()
-			if desc == "":
-				desc = "parsing error"
-			log.warning("Ignoring an incorrect message (%s): %s" % (desc, e))
+		except Exception as e:
+			log.warning("Failed to parse a TRXD message", exc_info=e)
 			self.cnt_burst_dropped_num += 1
 			return
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24022
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I625f5ae0ed9373cbece5f2201759ed0b51f0db68
Gerrit-Change-Number: 24022
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210430/08453cf0/attachment.htm>


More information about the gerrit-log mailing list