Change in osmo-bts[master]: osmo-bts-trx: implement TRXDv2 protocol support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Apr 30 19:49:20 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23833 )

Change subject: osmo-bts-trx: implement TRXDv2 protocol support
......................................................................


Patch Set 8:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/include/osmo-bts/scheduler.h 
File include/osmo-bts/scheduler.h:

https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/include/osmo-bts/scheduler.h@256 
PS7, Line 256: 	uint8_t _pdu_num;	/*!< Number of this PDU within the datagram */
> This field basically holds the number of parsed PDUs, so when it's 0 we expect TDMA frame number to  […]
Clarified.


https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c 
File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@726 
PS7, Line 726: #define TRX_UL_V2HDR_LEN	1 + 1 + 1 + 1 + 2 + 2
> Ack
Done.


https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@987 
PS7, Line 987: loop:
> * the indent level here is not deep at all […]
Done. I am not happy about this change though, and still don't see why do you both consider using 'goto' the evil. I don't see any benefits in this particular case. Diff looks ugly as expected. Splitting into smaller functions further looks pointless to me.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23833
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3532a6693bb335043ec390049138308991083e66
Gerrit-Change-Number: 23833
Gerrit-PatchSet: 8
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Apr 2021 19:49:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210430/c891e51d/attachment.htm>


More information about the gerrit-log mailing list