Change in osmo-bts[master]: osmo-bts-trx: assert PDU version in trx_if_send_burst()

fixeria gerrit-no-reply at lists.osmocom.org
Fri Apr 30 19:02:17 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23866 )

Change subject: osmo-bts-trx: assert PDU version in trx_if_send_burst()
......................................................................

osmo-bts-trx: assert PDU version in trx_if_send_burst()

If somehow the TRXC logic negotiates a non-supported TRXD PDU version,
then it's a serious bug in the code.  Let's add an assert() for that.

Change-Id: I301377bcebd5e2bbcfc18b3637253ef261bb5b2e
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c
index 073cad8..9e2cd75 100644
--- a/src/osmo-bts-trx/trx_if.c
+++ b/src/osmo-bts-trx/trx_if.c
@@ -1016,9 +1016,8 @@
 		break;
 
 	default:
-		LOGPPHI(l1h->phy_inst, DTRX, LOGL_ERROR,
-			"Requested TRXD PDU version %u is not supported\n", pdu_ver);
-		return -ENOTSUP;
+		/* Shall not happen */
+		OSMO_ASSERT(0);
 	}
 
 	buf[0] = ((pdu_ver & 0x0f) << 4) | br->tn;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23866
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I301377bcebd5e2bbcfc18b3637253ef261bb5b2e
Gerrit-Change-Number: 23866
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210430/52f154f4/attachment.htm>


More information about the gerrit-log mailing list