Change in osmo-bsc[master]: lchan_fsm: mode modify: fix missing timeouts and error transitions

[neels]

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23942 )

Change subject: lchan_fsm: mode modify: fix missing timeouts and error transitions
......................................................................

lchan_fsm: mode modify: fix missing timeouts and error transitions

Change-Id: I6364cfb78f661f5f7473dcec488e361e6a1dc9e4
---
M src/osmo-bsc/lchan_fsm.c
M src/osmo-bsc/net_init.c
M tests/timer.vty
3 files changed, 10 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  fixeria: Looks good to me, approved



diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index d2b7172..4eb95ff 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -217,6 +217,8 @@
 	[LCHAN_ST_WAIT_BEFORE_RF_RELEASE]	= { .T=3111 },
 	[LCHAN_ST_WAIT_RF_RELEASE_ACK]	= { .T=3111 },
 	[LCHAN_ST_WAIT_AFTER_ERROR]	= { .T=-3111 },
+	[LCHAN_ST_WAIT_RR_CHAN_MODE_MODIFY_ACK]	= { .T=-13 },
+	[LCHAN_ST_WAIT_RSL_CHAN_MODE_MODIFY_ACK]	= { .T=-14 },
 };
 
 /* Transition to a state, using the T timer defined in lchan_fsm_timeouts.
@@ -261,8 +263,8 @@
 	[LCHAN_ST_WAIT_RF_RELEASE_ACK] 		= LCHAN_ST_BORKEN,
 	[LCHAN_ST_WAIT_AFTER_ERROR] 		= LCHAN_ST_UNUSED,
 	[LCHAN_ST_BORKEN] 			= LCHAN_ST_BORKEN,
-	[LCHAN_ST_WAIT_RR_CHAN_MODE_MODIFY_ACK]	= LCHAN_ST_BORKEN,
-	[LCHAN_ST_WAIT_RSL_CHAN_MODE_MODIFY_ACK] 	= LCHAN_ST_BORKEN,
+	[LCHAN_ST_WAIT_RR_CHAN_MODE_MODIFY_ACK]	= LCHAN_ST_WAIT_RF_RELEASE_ACK,
+	[LCHAN_ST_WAIT_RSL_CHAN_MODE_MODIFY_ACK]	= LCHAN_ST_WAIT_RF_RELEASE_ACK,
 };
 
 #define lchan_fail(fmt, args...) lchan_fail_to(lchan_fsm_on_error[fi->state], fmt, ## args)
diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c
index 478c62f..6d88adb 100644
--- a/src/osmo-bsc/net_init.c
+++ b/src/osmo-bsc/net_init.c
@@ -54,6 +54,8 @@
 	{ .T=-10, .default_val=5, .desc="Timeout for fully configured MGW endpoint" },
 	{ .T=-11, .default_val=5, .desc="Timeout for Perform Location Response from SMLC" },
 	{ .T=-12, .default_val=5, .desc="Timeout for obtaining TA after BSSLAP TA Request" },
+	{ .T=-13, .default_val=5, .desc="Timeout for RR Channel Mode Modify ACK (BSC <-> MS)" },
+	{ .T=-14, .default_val=5, .desc="Timeout for RSL Channel Mode Modify ACK (BSC <-> BTS)" },
 	{ .T=-3111, .default_val=4, .desc="Wait time after lchan was released in error (should be T3111 + 2s)" },
 	{ .T=-3210, .default_val=20, .desc="After L3 Complete, wait for MSC to confirm" },
 	{}
diff --git a/tests/timer.vty b/tests/timer.vty
index 4b9ddbb..71dd2c1 100644
--- a/tests/timer.vty
+++ b/tests/timer.vty
@@ -27,6 +27,8 @@
 net: X10 = 5 s	Timeout for fully configured MGW endpoint (default: 5 s)
 net: X11 = 5 s	Timeout for Perform Location Response from SMLC (default: 5 s)
 net: X12 = 5 s	Timeout for obtaining TA after BSSLAP TA Request (default: 5 s)
+net: X13 = 5 s	Timeout for RR Channel Mode Modify ACK (BSC <-> MS) (default: 5 s)
+net: X14 = 5 s	Timeout for RSL Channel Mode Modify ACK (BSC <-> BTS) (default: 5 s)
 net: X3111 = 4 s	Wait time after lchan was released in error (should be T3111 + 2s) (default: 4 s)
 net: X3210 = 20 s	After L3 Complete, wait for MSC to confirm (default: 20 s)
 mgw: X2427 = 5 s	timeout for MGCP response from MGW (default: 5 s)
@@ -74,6 +76,8 @@
 net: X10 = 5 s	Timeout for fully configured MGW endpoint (default: 5 s)
 net: X11 = 5 s	Timeout for Perform Location Response from SMLC (default: 5 s)
 net: X12 = 5 s	Timeout for obtaining TA after BSSLAP TA Request (default: 5 s)
+net: X13 = 5 s	Timeout for RR Channel Mode Modify ACK (BSC <-> MS) (default: 5 s)
+net: X14 = 5 s	Timeout for RSL Channel Mode Modify ACK (BSC <-> BTS) (default: 5 s)
 net: X3111 = 4 s	Wait time after lchan was released in error (should be T3111 + 2s) (default: 4 s)
 net: X3210 = 20 s	After L3 Complete, wait for MSC to confirm (default: 20 s)
 mgw: X2427 = 5 s	timeout for MGCP response from MGW (default: 5 s)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23942
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6364cfb78f661f5f7473dcec488e361e6a1dc9e4
Gerrit-Change-Number: 23942
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210430/329574ab/attachment.htm>