Change in osmo-bts[master]: osmo-bts-trx: implement TRXDv2 protocol support

pespin gerrit-no-reply at lists.osmocom.org
Fri Apr 30 10:16:15 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23833 )

Change subject: osmo-bts-trx: implement TRXDv2 protocol support
......................................................................


Patch Set 7:

(6 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/include/osmo-bts/scheduler.h 
File include/osmo-bts/scheduler.h:

https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/include/osmo-bts/scheduler.h@256 
PS7, Line 256: 	uint8_t _pdu_num;	/*!< Number of this PDU within the datagram */
you mean the PDU position?


https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c 
File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@726 
PS7, Line 726: #define TRX_UL_V2HDR_LEN	1 + 1 + 1 + 1 + 2 + 2
missing ()


https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@852 
PS7, Line 852: 	bi->rssi = -(int8_t)buf[3];
are you sure this works correctly?
Example uint8_t buf[3] = 250:
Then, (int8_t)buf[3] gives a negative value (because it's more than 128), and applying "-" to it makes it positive again.


https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@987 
PS7, Line 987: loop:
do {


https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@1046 
PS7, Line 1046: 	if (bi.flags & TRX_BI_F_BATCH_IND) {
buf_len -= bi.burst_len;
buf += bi.burst_len;
bi._pdu_num++;
} while (bi.flags & TRX_BI_F_BATCH_IND)


https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@1114 
PS7, Line 1114: 	LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG,
not sure if we want to have this log here, looks really verbose.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23833
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3532a6693bb335043ec390049138308991083e66
Gerrit-Change-Number: 23833
Gerrit-PatchSet: 7
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Apr 2021 10:16:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210430/a070bd37/attachment.htm>


More information about the gerrit-log mailing list