Change in libosmo-sccp[master]: xua_asp_fsm: Fix IPA client role

laforge gerrit-no-reply at lists.osmocom.org
Thu Apr 29 19:15:10 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/23981 )

Change subject: xua_asp_fsm: Fix IPA client role
......................................................................

xua_asp_fsm: Fix IPA client role

The IPA server worked as expected, but the IPA client has some clear
logic bug that prevented it from working.  It shows that we never
really use any of that IPA/SCCPlite stuff after years in spec-compliant
SIGTRAN land.

A client now first waits for the IPA_REQ, sends its IPA_RESP, then
waits for the ACK, ...

Change-Id: Icfc32cad7d65c94dc21754b8f879afcf34d34a92
---
M src/xua_asp_fsm.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index ec85d21..dd1dddb 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -867,7 +867,7 @@
 			}
 		} else {
 			/* Client: We simply wait for an ID GET */
-			osmo_fsm_inst_state_chg(fi, IPA_ASP_S_WAIT_ID_ACK, 10, T_WAIT_ID_ACK);
+			osmo_fsm_inst_state_chg(fi, IPA_ASP_S_WAIT_ID_GET, 10, T_WAIT_ID_GET);
 		}
 		break;
 	}
@@ -1081,7 +1081,7 @@
 	[IPA_ASP_S_DOWN] = {
 		.in_event_mask = S(XUA_ASP_E_M_ASP_UP_REQ) |
 				 S(XUA_ASP_E_SCTP_EST_IND),
-		.out_state_mask = S(IPA_ASP_S_WAIT_ID_ACK) |
+		.out_state_mask = S(IPA_ASP_S_WAIT_ID_GET) |
 				  S(IPA_ASP_S_WAIT_ID_RESP),
 		.name = "ASP_DOWN",
 		.action = ipa_asp_fsm_down,

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/23981
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Icfc32cad7d65c94dc21754b8f879afcf34d34a92
Gerrit-Change-Number: 23981
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210429/3aa296d8/attachment.htm>


More information about the gerrit-log mailing list