Change in libosmo-sccp[master]: xua_as_fsm: Only delete a route for an IPA AS if we created one earlier

laforge gerrit-no-reply at lists.osmocom.org
Thu Apr 29 19:12:40 UTC 2021


Hello Jenkins Builder, pespin, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/libosmo-sccp/+/23983

to look at the new patch set (#4).

Change subject: xua_as_fsm: Only delete a route for an IPA AS if we created one earlier
......................................................................

xua_as_fsm: Only delete a route for an IPA AS if we created one earlier

The current code would potentially delete a route that was statically present in the
configuration in the following situation:

* route exists in config
* identical route is attempted to be added at AS-ACTIVE time, but fails
* route is unconditionally deleted at AS-DOWN time
* user now does 'write file' and has lost a route

Let's make sure we only delete the route if we added it previously.

Change-Id: I9ad5f7ebe0790e6c186b8ea1b12f204860a00cd2
Related: SYS#5422
---
M src/xua_as_fsm.c
1 file changed, 11 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/83/23983/4
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/23983
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I9ad5f7ebe0790e6c186b8ea1b12f204860a00cd2
Gerrit-Change-Number: 23983
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210429/bf00bbb6/attachment.htm>


More information about the gerrit-log mailing list