Change in libosmo-sccp[master]: osmo_ss7: Truncate route 'mask' to point code bit length
gerrit-no-reply at lists.osmocom.org
Thu Apr 29 18:05:06 UTC 2021
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/23982 )
Change subject: osmo_ss7: Truncate route 'mask' to point code bit length
Patch Set 2:
PS2, Line 199: /* truncate pc or mask mask to maximum permitted length. This solves
> s/mask mask/pc mask/
PS2, Line 795: mask = osmo_ss7_pc_normalize(&rtbl->inst->cfg.pc_fmt, mask);
> And here warn before doing this, in order to get callers fixed? […]
I don't think it's illegal. You can always specify more higher bits in a kind of 'netmask' use case and expect it to work. I think it's the routing system here that has the job of properly normalizing those.
Particularly in SS7 where length of point codes is configurable, you would otherwise have to add a lot of code at every caller instead of simply passing 0xffffff in a function argument for the mask as we currently do.
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/23982
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Apr 2021 18:05:06 +0000
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log