Change in libosmocore[master]: ns2: Allow setting the socket priority for a UDP bind

laforge gerrit-no-reply at lists.osmocom.org
Thu Apr 29 18:02:02 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23976 )

Change subject: ns2: Allow setting the socket priority for a UDP bind
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23976/1/src/gb/gprs_ns2_udp.c 
File src/gb/gprs_ns2_udp.c:

https://gerrit.osmocom.org/c/libosmocore/+/23976/1/src/gb/gprs_ns2_udp.c@542 
PS1, Line 542: 		rc = osmo_sock_set_priority(priv->fd.fd, priority);
> I meant returning before calling setsockopt, since it's clear this function shouldn't call it if fd  […]
I don't think we generally everywhere check things that are safe (like passing a negative integer to a syscall.  But if you think it's worth it, it should be added as a separate patch, so we can touch all the related functions at least in this file, which at the very least includes the set_dscp() above.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23976
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifdfa086ce1c8d62b256abb3454b70cf53da9dcdb
Gerrit-Change-Number: 23976
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Apr 2021 18:02:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210429/21781d11/attachment.htm>


More information about the gerrit-log mailing list