Change in libosmo-sccp[master]: osmo_ss7: Truncate route 'mask' to point code bit length

pespin gerrit-no-reply at lists.osmocom.org
Thu Apr 29 17:38:10 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/23982 )

Change subject: osmo_ss7: Truncate route 'mask' to point code bit length
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmo-sccp/+/23982/1/src/osmo_ss7.c 
File src/osmo_ss7.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/23982/1/src/osmo_ss7.c@780 
PS1, Line 780: 	mask &= (1 << osmo_ss7_pc_width(&rtbl->inst->cfg.pc_fmt))-1;
What about having a function/macro doing this, and let the callers use it, and here simply fail (or simply warn) if the mask is detected too large?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/23982
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I5d5c828de45724d93a0461bb0dd7858fd8378acd
Gerrit-Change-Number: 23982
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Apr 2021 17:38:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210429/8b486d8f/attachment.htm>


More information about the gerrit-log mailing list