This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23980 ) Change subject: ipa_ccm_make_id_resp: Make it work at all ...................................................................... ipa_ccm_make_id_resp: Make it work at all This could never possibly have worked. When iterating over the different IEs to encode, we must of course use the tag of the current iterator item, and not the hard-coded value of the second tag in the list. Change-Id: I148799c5bdb95f70118691c1150330ebac4fdf21 --- M src/gsm/ipa.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/23980/1 diff --git a/src/gsm/ipa.c b/src/gsm/ipa.c index 7379d06..8fc6eb7 100644 --- a/src/gsm/ipa.c +++ b/src/gsm/ipa.c @@ -388,7 +388,7 @@ tag = msgb_put(msg, 3 + strlen(str) + 1); tag[0] = 0x00; tag[1] = 1 + strlen(str) + 1; - tag[2] = ies_req[1]; + tag[2] = ies_req[i]; memcpy(tag + 3, str, strlen(str) + 1); } ipa_prepend_header(msg, IPAC_PROTO_IPACCESS); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I148799c5bdb95f70118691c1150330ebac4fdf21 Gerrit-Change-Number: 23980 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210429/ff400842/attachment.htm>