Change in osmo-msc[master]: Fill Last Used E-UTRAN PLMN Id when in CSFB

fixeria gerrit-no-reply at lists.osmocom.org
Thu Apr 29 12:08:45 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/23915 )

Change subject: Fill Last Used E-UTRAN PLMN Id when in CSFB
......................................................................


Patch Set 3: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/c/osmo-msc/+/23915/3/src/libmsc/sgs_iface.c 
File src/libmsc/sgs_iface.c:

https://gerrit.osmocom.org/c/osmo-msc/+/23915/3/src/libmsc/sgs_iface.c@658 
PS3, Line 658: LOGL_INFO
sounds more like a NOTICE?


https://gerrit.osmocom.org/c/osmo-msc/+/23915/3/src/libmsc/sgs_iface.c@943 
PS3, Line 943: LOGL_INFO
sounds more like a NOTICE?


https://gerrit.osmocom.org/c/osmo-msc/+/23915/3/src/libmsc/sgs_iface.c@944 
PS3, Line 944: "
missing space between sentences



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/23915
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic5f175b179973d0a50d94f00e15f5a3e332605fc
Gerrit-Change-Number: 23915
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 29 Apr 2021 12:08:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210429/90ba0942/attachment.htm>


More information about the gerrit-log mailing list