Change in osmo-ci[master]: OBS: require PROJ environment variable to be set

pespin gerrit-no-reply at lists.osmocom.org
Thu Apr 29 10:57:12 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/23949 )

Change subject: OBS: require PROJ environment variable to be set
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-ci/+/23949/3/scripts/osmocom-latest-packages.sh 
File scripts/osmocom-latest-packages.sh:

https://gerrit.osmocom.org/c/osmo-ci/+/23949/3/scripts/osmocom-latest-packages.sh@4 
PS3, Line 4: # * PROJ: the OBS namespace to upload to (e.g. network:osmocom:latest)
I think it's worth adding "" around network:osmocom:latest, this way it's immediately clear that's the expected value to pass into the variable, and that you are just no mentioning some sort of reference or URL or whatever.


https://gerrit.osmocom.org/c/osmo-ci/+/23949/3/scripts/osmocom-nightly-packages.sh 
File scripts/osmocom-nightly-packages.sh:

https://gerrit.osmocom.org/c/osmo-ci/+/23949/3/scripts/osmocom-nightly-packages.sh@4 
PS3, Line 4: # * PROJ: the OBS namespace to upload to (e.g. network:osmocom:nightly)
same



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/23949
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: If49ce217e77716b63dfde9139e869672a54b66a2
Gerrit-Change-Number: 23949
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Apr 2021 10:57:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210429/5979c673/attachment.htm>


More information about the gerrit-log mailing list