Change in libosmo-abis[master]: e1_input: Allow (vty) configuration of IP DSCP and socket priority

laforge gerrit-no-reply at lists.osmocom.org
Thu Apr 29 09:05:15 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/23958 )

Change subject: e1_input: Allow (vty) configuration of IP DSCP and socket priority
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmo-abis/+/23958/2/include/internal.h 
File include/internal.h:

https://gerrit.osmocom.org/c/libosmo-abis/+/23958/2/include/internal.h@24 
PS2, Line 24: extern s
it's not really nice having this global variable used as interface between two parts of the code base, but I tried another approach first and it was even more ugly (get/set functions for each of the four parameters, i.e. 8 symbols that also pollute the global namespace).

the e1_input code is ancient.  The IPA support in it was a big hack introduced for nanoBTS support at some point later.  It is already super ugly, no matter what we do...



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/23958
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I8991dd6eb406a5b9a70498974fc1ad339452f871
Gerrit-Change-Number: 23958
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Apr 2021 09:05:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210429/05e20572/attachment.htm>


More information about the gerrit-log mailing list