Change in osmo-ttcn3-hacks[master]: msc: Verify CommonID contains LastUsedEutranPLMNId when in CSFB

fixeria gerrit-no-reply at lists.osmocom.org
Wed Apr 28 20:06:17 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23969 )

Change subject: msc: Verify CommonID contains LastUsedEutranPLMNId when in CSFB
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23969/1/library/BSSMAP_Templates.ttcn 
File library/BSSMAP_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23969/1/library/BSSMAP_Templates.ttcn@1179 
PS1, Line 1179: 			return template BSSAMAP_IE_LastUsedEUTRANPLMNId {
Not critical, but I find this spacing weird.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23969/1/msc/MSC_Tests.ttcn 
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23969/1/msc/MSC_Tests.ttcn@a4644 
PS1, Line 4644: 
unrelated



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23969
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I161529fd9c8cacb7d17ea18660998df06bb0b575
Gerrit-Change-Number: 23969
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Apr 2021 20:06:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210428/aa6a3eb1/attachment.htm>


More information about the gerrit-log mailing list