Change in osmo-gsm-manuals[master]: Add new common chapter about QoS, IP DSCP and IEEE 802.1q PCP

laforge gerrit-no-reply at lists.osmocom.org
Wed Apr 28 15:39:35 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23926 )

Change subject: Add new common chapter about QoS, IP DSCP and IEEE 802.1q PCP
......................................................................


Patch Set 6:

(4 comments)

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23926/6/common/chapters/glossary.adoc 
File common/chapters/glossary.adoc:

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23926/6/common/chapters/glossary.adoc@80 
PS6, Line 80: (
> Here too, BTW.
thanks, fixed in  https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23944


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23926/6/common/chapters/glossary.adoc@85 
PS6, Line 85: (
> Missing closing brace for this one.
thanks, fixed in  https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23944


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23926/6/common/chapters/glossary.adoc@362 
PS6, Line 362: <<
> Missing closing '>>'
thanks, fixed in  https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23944


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23926/6/common/chapters/qos-dscp-pcp.adoc 
File common/chapters/qos-dscp-pcp.adoc:

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23926/6/common/chapters/qos-dscp-pcp.adoc@161 
PS6, Line 161: include::{srcdir}/chapters/qos-example.adoc[]
> AFAIU, this file needs to be in the projects's source tree, right?
yes, that's correct.  So every program can bring its own example into this section.  That's why it uses {scrdir} and not common in the path.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23926
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: Id344c29eda2a9b3e36376302b425e9db1f6c0f28
Gerrit-Change-Number: 23926
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Apr 2021 15:39:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210428/aea8c491/attachment.htm>


More information about the gerrit-log mailing list