Change in osmo-bsc[master]: Lb: make sure we never have missing timer configurability

neels gerrit-no-reply at lists.osmocom.org
Wed Apr 28 14:32:31 UTC 2021


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23937 )


Change subject: Lb: make sure we never have missing timer configurability
......................................................................

Lb: make sure we never have missing timer configurability

After I found that X12 was missing from the VTY config, make sure that
no timers have been forgotten in lcs_ta_req.c: change the default
timeout to -1. We will notice missing timers during testing.

Change-Id: I7c0b098622548bf0f0374c304522e6a9db0331e3
---
M src/osmo-bsc/lcs_ta_req.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/37/23937/1

diff --git a/src/osmo-bsc/lcs_ta_req.c b/src/osmo-bsc/lcs_ta_req.c
index 3b859a7..bcee6e1 100644
--- a/src/osmo-bsc/lcs_ta_req.c
+++ b/src/osmo-bsc/lcs_ta_req.c
@@ -56,7 +56,7 @@
 	osmo_tdef_fsm_inst_state_chg(FI, STATE, \
 				     lcs_ta_req_fsm_timeouts, \
 				     (bsc_gsmnet)->T_defs, \
-				     5)
+				     -1)
 
 #define lcs_ta_req_fail(cause, fmt, args...) do { \
 		LOG_LCS_TA_REQ(lcs_ta_req, LOGL_ERROR, "BSSLAP TA Request failed in state %s: " fmt "\n", \

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23937
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7c0b098622548bf0f0374c304522e6a9db0331e3
Gerrit-Change-Number: 23937
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210428/cf75888f/attachment.htm>


More information about the gerrit-log mailing list