Change in libosmocore[master]: socket: reduce code duplication, introduce socket_helper_tail()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Apr 28 12:42:35 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23933 )

Change subject: socket: reduce code duplication, introduce socket_helper_tail()
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+1
> 
> Not sure if it helps making code more readable, but ok.

I don't like code duplication and vote for this patch, but agree with Pau here. What about using a more concrete name than socket_helper_tail(), e.g. socket_set_nonblock()?


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23933
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I95056940ddc26b65f63eedaeaab6882edaef6317
Gerrit-Change-Number: 23933
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Apr 2021 12:42:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210428/10b9e22b/attachment.htm>


More information about the gerrit-log mailing list