Change in osmo-bts[master]: Allow user to specify IP DSCP for OML and RSL, too

fixeria gerrit-no-reply at lists.osmocom.org
Wed Apr 28 12:29:15 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23923 )

Change subject: Allow user to specify IP DSCP for OML and RSL, too
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/23923/1/src/common/bts_trx.c 
File src/common/bts_trx.c:

https://gerrit.osmocom.org/c/osmo-bts/+/23923/1/src/common/bts_trx.c@205 
PS1, Line 205: link ? "up" : "down");
The 'link' can be NULL here, while you unconditionally dereference it below. I think a better place for setting DSCP would be sign_link_up()? There you definitely know that the link is up, and should not be NULL.


https://gerrit.osmocom.org/c/osmo-bts/+/23923/1/src/common/vty.c 
File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/23923/1/src/common/vty.c@604 
PS1, Line 604: BTS_VTY_ATTR_NEW_LCHAN
This is not the case, because it actually applies on the OML link establishment. I think we need a new VTY attribute for that - BTS_VTY_ATTR_RESTART_ABIS_OML_LINK.


https://gerrit.osmocom.org/c/osmo-bts/+/23923/1/src/common/vty.c@618 
PS1, Line 618: BTS_VTY_ATTR_NEW_LCHAN
Same here, BTS_VTY_ATTR_RESTART_ABIS_RSL_LINK.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23923
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic302a695453514459fa27400027154e7e8b74e0e
Gerrit-Change-Number: 23923
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Apr 2021 12:29:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210428/dbb9855d/attachment.htm>


More information about the gerrit-log mailing list