Change in osmo-mgw[master]: TOS bits != DSCP

laforge gerrit-no-reply at lists.osmocom.org
Wed Apr 28 10:44:40 UTC 2021


Hello Jenkins Builder, pespin, dexter, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-mgw/+/23924

to look at the new patch set (#2).

Change subject: TOS bits != DSCP
......................................................................

TOS bits != DSCP

We have VTY options that allow to set the DSCP value.  However, we
then call a function to set the TOS bits in the kernel.  This is
very wrong.  The DSCP is only the upper 6 bits of the 8-bit TOS
value, and hence we are mussing that translation.

As libosmocore now has a helper function osmo_sock_set_dscp(),
let's make use of it and don't care about the low-level details.

However, this means we need to finally remove the deprecated
alias for "rtp ip-tos <0-255>".

Closes: OS#5137
Change-Id: I9c18c90273be97aedd2ad212b82f650e35c32851
Depends: libosmocore.git Ia4ba389a5b7e3e9d5f17a742a900d6fd68c08e40
---
M TODO-RELEASE
M doc/examples/osmo-mgw/osmo-mgw-abis_e1.cfg
M doc/examples/osmo-mgw/osmo-mgw.cfg
M doc/manuals/chapters/configuration.adoc
M include/osmocom/mgcp/mgcp_network.h
M src/libosmo-mgcp/mgcp_network.c
M src/libosmo-mgcp/mgcp_osmux.c
M src/libosmo-mgcp/mgcp_vty.c
8 files changed, 9 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/24/23924/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/23924
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I9c18c90273be97aedd2ad212b82f650e35c32851
Gerrit-Change-Number: 23924
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210428/d8dd7cd7/attachment.htm>


More information about the gerrit-log mailing list