Change in osmo-bts[master]: common/abis: fix the use of deprecated e1inp_line_get() API

pespin gerrit-no-reply at lists.osmocom.org
Wed Apr 28 10:10:11 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23919 )

Change subject: common/abis: fix the use of deprecated e1inp_line_get() API
......................................................................


Patch Set 2:

ok indeed, those braces may be needed.
It may be a good idea to wrap OSMO_ASSERT into a "do { if() {} } while(0)", otherwise that looks really prone to error!


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23919
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I41a5fd13a7fa40e16bcf1a8099624b654274cee3
Gerrit-Change-Number: 23919
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Apr 2021 10:10:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210428/3d942032/attachment.htm>


More information about the gerrit-log mailing list