Change in osmo-bts[master]: common/abis: fix the use of deprecated e1inp_line_get() API

pespin gerrit-no-reply at lists.osmocom.org
Wed Apr 28 10:07:56 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23919 )

Change subject: common/abis: fix the use of deprecated e1inp_line_get() API
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/23919/2/src/common/abis.c 
File src/common/abis.c:

https://gerrit.osmocom.org/c/osmo-bts/+/23919/2/src/common/abis.c@284 
PS2, Line 284: 	if (line) {
I think it's fine not using curly braces here, are you sure they are needed?

BTW, the macros look weird, why do they have a ";" at the end? they should afaiu (I think I may have writen them myself lol):
"""
#define e1inp_line_get2(line, USE) OSMO_ASSERT( osmo_use_count_get_put(&(line)->use_count, USE, 1) == 0 );
#define e1inp_line_put2(line, USE) OSMO_ASSERT( osmo_use_count_get_put(&(line)->use_count, USE, -1) == 0 );
"""



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23919
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I41a5fd13a7fa40e16bcf1a8099624b654274cee3
Gerrit-Change-Number: 23919
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Apr 2021 10:07:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210428/b5ee3a98/attachment.htm>


More information about the gerrit-log mailing list