Change in osmo-bts[master]: common/abis: fix the use of deprecated e1inp_line_get() API

fixeria gerrit-no-reply at lists.osmocom.org
Tue Apr 27 17:01:35 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/23919 )


Change subject: common/abis: fix the use of deprecated e1inp_line_get() API
......................................................................

common/abis: fix the use of deprecated e1inp_line_get() API

We need curly braces becausee1inp_line_get2() is basically a macro
that calls OSMO_ASSERT(), which in its turn contains an 'if' stmt.

Change-Id: I41a5fd13a7fa40e16bcf1a8099624b654274cee3
---
M src/common/abis.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/19/23919/1

diff --git a/src/common/abis.c b/src/common/abis.c
index 5b914c7..be7e906 100644
--- a/src/common/abis.c
+++ b/src/common/abis.c
@@ -281,9 +281,9 @@
 	bts_dev_info.location2 = model_name;
 
 	line = e1inp_line_find(0);
-	if (line)
-		e1inp_line_get(line); /* We want a new reference for returned line */
-	else
+	if (line) {
+		e1inp_line_get2(line, __FILE__); /* We want a new reference for returned line */
+	} else
 		line = e1inp_line_create(0, "ipa"); /* already comes with a reference */
 	if (!line)
 		return NULL;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23919
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I41a5fd13a7fa40e16bcf1a8099624b654274cee3
Gerrit-Change-Number: 23919
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210427/88be70ed/attachment.htm>


More information about the gerrit-log mailing list