Change in osmo-bsc[master]: Lb: RESET FSM: never send sccp_user == NULL

neels gerrit-no-reply at lists.osmocom.org
Tue Apr 27 15:34:53 UTC 2021


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23913 )


Change subject: Lb: RESET FSM: never send sccp_user == NULL
......................................................................

Lb: RESET FSM: never send sccp_user == NULL

A crash was reported in bssmap_le_tx_reset() sending a RESET with
sccp_user == NULL. A previous patch fixes what I infer as the root
cause, but I thought let's also have this additional safeguard.

Related: OS#5134
Change-Id: I13834c4e576e8d33e67cb63e222b41255cd94875
---
M src/osmo-bsc/lb.c
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/13/23913/1

diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c
index 0ff7c5c..e23de93 100644
--- a/src/osmo-bsc/lb.c
+++ b/src/osmo-bsc/lb.c
@@ -58,6 +58,11 @@
 		},
 	};
 
+	if (!bsc_gsmnet->smlc->sccp_user) {
+		LOGP(DRESET, LOGL_DEBUG, "Not sending RESET to SMLC, Lb link down\n");
+		return -1;
+	}
+
 	ss7 = osmo_ss7_instance_find(bsc_gsmnet->smlc->cs7_instance);
 	OSMO_ASSERT(ss7);
 	LOGP(DRESET, LOGL_INFO, "Sending RESET to SMLC: %s\n", osmo_sccp_addr_name(ss7, &bsc_gsmnet->smlc->smlc_addr));

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23913
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I13834c4e576e8d33e67cb63e222b41255cd94875
Gerrit-Change-Number: 23913
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210427/1b8390a6/attachment.htm>


More information about the gerrit-log mailing list