Change in osmo-bsc[master]: stats: add BTS uptime counter

dexter gerrit-no-reply at lists.osmocom.org
Tue Apr 27 10:11:52 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23234 )

Change subject: stats: add BTS uptime counter
......................................................................


Patch Set 3:

Hello Michael,

(Daniel is on holiday at the moment)

As far as I understand this patch the only problem here is that a rate counter instead of a stats item is used. Uptime is indeed not really a rate, I think its indeed better to use a stats item. Unfortunately I personally did not use stats items before either but I would suggest to have a look at stats_test.c in libosmocore. There is also already a bts_stat_desc in bts.c. It should not be that difficult to migrate your patch from rate counters to stats items.

Counting the downtime makes also more sense to me since networks usually run 24/2 and if there is a problem it is easier to spot by looking at the downtime.

best regards,
Philipp


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23234
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib17674bbe95e828cebff12de9e0b30f06447ef6c
Gerrit-Change-Number: 23234
Gerrit-PatchSet: 3
Gerrit-Owner: iedemam <michael at kapsulate.com>
Gerrit-Assignee: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Tue, 27 Apr 2021 10:11:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210427/2a150e3b/attachment.htm>


More information about the gerrit-log mailing list