Change in osmo-ttcn3-hacks[master]: pcu: Drop test TC_t3169

pespin gerrit-no-reply at lists.osmocom.org
Tue Apr 27 09:33:10 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23903 )

Change subject: pcu: Drop test TC_t3169
......................................................................

pcu: Drop test TC_t3169

This test was added a long time ago to test what used to be the previous
early implementation of T3169, which didn't follow specs as per TS
44.060.
Since recently, osmo-pcu supports tracking UL PDCH blocks and hence
properly implementing N3101 and N3101, finally also implementing T3169
correctly.
The counters N3101/3 and timer T3169 are already being tested in
following tests:
TC_n3101_max_t3169
TC_n3103_max_t3169

Since osmo-pcu I2cec531e2633281b88f69ba065c0105580c81076, time-based
T3169 is dropped and TC_t3169 doesn't pass anymore, since it had wrong
expectancies (because it's not sending RTS to osmo-pcu, hence not
triggering USF/RRBP N3101/3 timeouts).

Change-Id: I023fb406f1df6e67e16982cb11dc1fcb6fb9b544
---
M pcu/PCU_Tests.ttcn
1 file changed, 0 insertions(+), 44 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  osmith: Looks good to me, approved



diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 52d6271..f1506a1 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -1270,49 +1270,6 @@
 	f_dl_data_exp_cs(f_rlcmac_block_int2cs_mcs(g_mcs_max_dl, true), bssgp_ms_racap_egprs_def);
 }
 
-/* Verify PCU drops TBF after some time of inactivity. */
-testcase TC_t3169() runs on RAW_PCU_Test_CT {
-	var PCUIF_info_ind info_ind;
-	var RlcmacDlBlock dl_block;
-	var uint32_t unused_fn;
-	var GprsMS ms;
-
-	/* Initialize NS/BSSGP side */
-	f_init_bssgp();
-	/* Initialize GPRS MS side */
-	f_init_gprs_ms();
-	ms := g_ms[0]; /* We only use first MS in this test */
-
-	info_ind := valueof(ts_PCUIF_INFO_default(c_PCUIF_Flags_noMCS));
-	/* Set timer to 1 sec (default 5) to speedup test: */
-	info_ind.t3169 := 1;
-
-	/* Initialize the PCU interface abstraction */
-	f_init_raw(testcasename(), info_ind);
-
-	/* Establish BSSGP connection to the PCU */
-	f_bssgp_establish();
-	f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli);
-
-	/* Establish an Uplink TBF */
-	f_ms_establish_ul_tbf(ms);
-
-	/* Send one UL block (with TLLI since we are in One-Phase Access
-	   contention resoultion) and make sure it is ACKED fine */
-	f_ms_tx_ul_data_block(ms, f_rnd_octstring(10), cv := 1, with_tlli := true, fn := ms.ul_tbf.start_time_fn)
-	f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, unused_fn);
-	/* UL block should NOT be received in SGSN, since we didn't get CV=0 */
-
-	/* Wait until T3169 fires (plus 1 extra sec to make sure) */
-	f_sleep(int2float(info_ind.t3169) + 1.0);
-
-	/* Send an UL block once again, the TBF should be gone by now so no ACK */
-	f_ms_tx_ul_data_block(ms, f_rnd_octstring(10), cv := 0)
-	f_rx_rlcmac_dl_block_exp_dummy(dl_block);
-
-	f_shutdown(__BFILE__, __LINE__, final := true);
-}
-
 /* Validate what happens when RACH to get UL TBF and then PCU receives no UL
  * data. It should end up in N3101 reaching N3101_MAX and finally triggering
  * T3169. See OS#5033 */
@@ -5773,7 +5730,6 @@
 	execute( TC_mcs_max_ul() );
 	execute( TC_mcs_initial_dl() );
 	execute( TC_mcs_max_dl() );
-	execute( TC_t3169() );
 	execute( TC_n3101_max_t3169() );
 	execute( TC_n3103_max_t3169() );
 	execute( TC_x2031_t3191() );

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23903
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I023fb406f1df6e67e16982cb11dc1fcb6fb9b544
Gerrit-Change-Number: 23903
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210427/d5fc3e0f/attachment.htm>


More information about the gerrit-log mailing list