This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877 ) Change subject: pcu: Take into account TbfStartingTime ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877/2/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877/2/pcu/GPRS_Components.ttcn@691 PS2, Line 691: i == 1 > After reading the comment below, I wonder if this should be i > 0 It doesn't matter, the imporant part is that we set fn=0 once after first round, so i==1 is actually better than i>0 (to avoid setting the variable on each loop pass). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877/2/pcu/GPRS_Components.ttcn@693 PS2, Line 693: avaialble > (available) Ack https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877/2/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877/2/pcu/PCU_Tests.ttcn@2768 PS2, Line 2768: ms.ul_tbf.start_time_fn > this is passed as "cv" parameter here, is this correct? indeed, that's a typo ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6dad0f3167ace8d4a763fed971db94f32faf6ced Gerrit-Change-Number: 23877 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Tue, 27 Apr 2021 08:23:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210427/cca3e724/attachment.htm>