Change in osmo-pcu[master]: ul_tbf: Clean up handle_tbf_reject()

pespin gerrit-no-reply at lists.osmocom.org
Mon Apr 26 15:19:15 UTC 2021


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-pcu/+/23907

to look at the new patch set (#3).

Change subject: ul_tbf: Clean up handle_tbf_reject()
......................................................................

ul_tbf: Clean up handle_tbf_reject()

Document the function, make it look similar to usual TBF creation path
tbf_alloc_ul()->tbf_alloc_ul_tbf->tbf::setup(), which it mimics with
some differences.
Get rid of unneeded stuff like creating MS and settings its TLLI (that's
already done in only caller of the function). There's no need for
calling update_ms() either.

Change-Id: I61df2e4f0f0df1f8db941741a2d35a2319252c5e
---
M src/pdch.cpp
M src/tbf_ul.cpp
M src/tbf_ul.h
M tests/tbf/TbfTest.cpp
M tests/tbf/TbfTest.err
5 files changed, 24 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/07/23907/3
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23907
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I61df2e4f0f0df1f8db941741a2d35a2319252c5e
Gerrit-Change-Number: 23907
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210426/d566f60f/attachment.htm>


More information about the gerrit-log mailing list