Change in libosmo-sccp[master]: ipa: Move automatic route add/del from ASP to AS level

laforge gerrit-no-reply at lists.osmocom.org
Mon Apr 26 08:56:43 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/23894 )

Change subject: ipa: Move automatic route add/del from ASP to AS level
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmo-sccp/+/23894/1/src/xua_as_fsm.c 
File src/xua_as_fsm.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/23894/1/src/xua_as_fsm.c@381 
PS1, Line 381: 			ipa_del_route(fi);
> Shouldn't this be done in INACTIVE?
AFAIR, In theory, the INACTIVE state allows queueing of messages which are then sent once it becomes ACTIVE again.  We don't really support this yet.

I'll check once more how it works with the RKM on M3UA to ensure IPA is following that as closely as possible.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/23894
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Idb602beae3e9bc19f7bd96355c02ec8dfd9c5d6c
Gerrit-Change-Number: 23894
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Apr 2021 08:56:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210426/53e50fd6/attachment.htm>


More information about the gerrit-log mailing list